Add image overrides for CAPI/CAPRKE2 images #860
Conversation
| images: | ||
| - name: "cluster-api" | ||
| repository: "https://github.com/rancher-sandbox/cluster-api" | ||
| tag: "v1.7.7" |
There was a problem hiding this comment.
FYI I figured out why the CoreProvider override is not enough in my environment - we're following the airgapped docs and creating configmaps from the upstream manifests, we need to update the docs (and our edge airgap resources chart) to align with the forks instead
# kubectl get cm -n capi-system core-cluster-api-v1.7.7 -o yaml | grep image:
image: registry.k8s.io/cluster-api/cluster-api-controller:v1.7.7
# kubectl get deployment -n capi-system -o yaml | grep image:
image: registry.k8s.io/cluster-api/cluster-api-controller:v1.7.7
There was a problem hiding this comment.
Actually, it seems that CM is created even in the non-airgapped scenario so my analysis above may be incorrect, I still think we need to align the airgapped docs though?
There was a problem hiding this comment.
Can you please check if the configMap with overrides is mounted into CAPI operator pod? If it is not, then this will not effective (meaning clusterctl-config.yaml configMap). May happen if capi operator is not installed as a dependency of turtles within chart settings.
You don’t need to update your generated air-gap configmaps if you only need an image to point to the registry override we are specifying here, upstream manifests will work just fine. This will be performed by regular image overrides functionality implemented upstream (with a fix recently, so it should work as long as CM is mounted) and applied to all versions of manifests, even the air-gapped ones you have.
There was a problem hiding this comment.
Actually, it seems that CM is created even in the non-airgapped scenario so my analysis above may be incorrect, I still think we need to align the airgapped docs though?
There was a problem hiding this comment.
This change should specify an override to registry image, as displayed in example kubernetes-sigs/cluster-api-operator#616 (comment)
Specifying an override tag will need a change to updatecli procedure, and may forcefully override the tag user specifies on CAPIProvider, so it should not be set here.
furkatgofurov7
force-pushed
the
use-capi-caprke2-image-overrides
branch
5 times, most recently
from
09bd702 to
8dc93e8
Compare
Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
force-pushed
the
use-capi-caprke2-image-overrides
branch
from
8dc93e8 to
0e92bda
Compare
|
Superseded by: #874 |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: